Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow GHC 9.10 #530

Merged
merged 2 commits into from
May 20, 2024
Merged

Allow GHC 9.10 #530

merged 2 commits into from
May 20, 2024

Conversation

erikd
Copy link
Contributor

@erikd erikd commented May 20, 2024 •
edited
Loading

Tested on Linux with GHC versions 8.10.7, 9.6.5, 9.8.2 and 9.10.1

erikd
erikd commented May 20, 2024
View reviewed changes
hedgehog-test-laws/hedgehog-test-laws.cabal
@@ -54,13 +54,12 @@ test-suite test
build-depends:
hedgehog
, base >= 3 && < 5
-- https://github.com/conal/checkers/issues/44
, checkers >= 0.5 && < 0.5.5
, checkers >= 0.5 && < 0.8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkers issues has been fixed and I assume the new version on Hackage has the fix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest version on hackage is 0.6 so < 0.8 will keep CI happy for a while.

moodmosaic
moodmosaic approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @erikd 💯

@moodmosaic moodmosaic merged commit 0040de7 into hedgehogqa:master May 20, 2024
28 checks passed
@erikd
Copy link
Contributor Author

erikd commented May 20, 2024

A new release would be much appreciated too.

@moodmosaic
Copy link
Member

Let's wait to see what we will end up doing in #522 (comment) and then we can release. 🎉

@tomjaguarpaw
Copy link
Contributor

I wonder if we could at least get a Hackage revision to 1.4, to loosen these bounds?

@moodmosaic
Copy link
Member

Absolutely! Done 👍

Published new revision for hedgehog-1.4. It will be available to users as soon as they update their package index (e.g. cabal update).

  • Changed the library component's library dependency on template-haskell from

    >=2.10 && <2.22

    to

    >=2.10 && <2.23

And hopefully a release coming up this week. 🎉

@tomjaguarpaw
Copy link
Contributor

Thank you! That let me test 9.10 on tomland: kowainik/tomland#445

@moodmosaic
Copy link
Member

Awesome 🎉

@moodmosaic moodmosaic changed the title Make it build with ghc 9.10 Build with ghc 9.10 Jul 24, 2024
@moodmosaic moodmosaic changed the title Build with ghc 9.10 Build with GHC 9.10 Jul 24, 2024
@moodmosaic moodmosaic changed the title Build with GHC 9.10 Allow GHC 9.10 Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moodmosaic moodmosaic moodmosaic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikd @moodmosaic @tomjaguarpaw